Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

can't use component as a context name #1213

Closed
Rich-Harris opened this issue Mar 7, 2018 · 1 comment · Fixed by #1216
Closed

can't use component as a context name #1213

Rich-Harris opened this issue Mar 7, 2018 · 1 comment · Fixed by #1216
Labels
bug

Comments

@Rich-Harris
Copy link
Member

Rich-Harris commented Mar 7, 2018 •
edited
Loading

Eek, I really caused some damage with #1173: https://svelte.technology/repl?version=1.56.2&gist=a3cf9f2071401f3d6ee7a92e049b8d97

The line var component = state.component unsurprisingly breaks everything. This is the root cause of sveltejs/v2.svelte.dev#214.
@Rich-Harris Rich-Harris added the bug label Mar 7, 2018
@Rich-Harris
Copy link
Member Author

Same is true for 'state': https://svelte.technology/repl?version=1.56.2&gist=0961ec1f092efd58571345fc5b5515f2

Rich-Harris added a commit that referenced this issue Mar 7, 2018
@Rich-Harris
prevent context variables being called component or state - fixes #1213
fad5ccd
@Rich-Harris Rich-Harris mentioned this issue Mar 7, 2018
Merged
Rich-Harris added a commit that referenced this issue Mar 7, 2018
@Rich-Harris
Merge pull request #1216 from sveltejs/gh-1213
a49c4fa 
prevent context variables being called component or state
This was referenced Mar 14, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

prevent context variables being called component or state sveltejs/svelte
1 participant
@Rich-Harris