-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Svelte 5: List of libraries not working out of the box #10359
Comments
|
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
@mstachowiak what doesn't work exactly here? #8301 is present in Svelte 4 as well. The library should work since it sets the |
This comment was marked as resolved.
This comment was marked as resolved.
Adjusts the escaping mechanism done for server compilation. For template literals it's now only applied when explicitly told, which is the case for generated literals from the html template. Fixes a bug where a template literal string inside the `@html` tag was wrongfully escaped (#10359 (comment))
Adjusts the escaping mechanism done for server compilation. For template literals it's now only applied when explicitly told, which is the case for generated literals from the html template. Fixes a bug where a template literal string inside the `@html` tag was wrongfully escaped (#10359 (comment))
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
It seems like a ton of libraries are using |
TanStack/table#5213. The svelte wrapper for TanStack Table is using |
This comment was marked as resolved.
This comment was marked as resolved.
svelteflow.dev - the following error occurs as soon as the dep is installed
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
* fix: handle component binding mutation #10359 (comment) * alternative approach to mutating props (#10788) Co-authored-by: Rich Harris <rich.harris@vercel.com> --------- Co-authored-by: Rich Harris <richard.a.harris@gmail.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This can be marked as fixed. For now, the fix only exists in the |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Wow that was fast @dummdidumm! I updated both Strava and Github analysis and that does appear to fix this issue. I'm seeing some other issues but I'll investigate and report separately (mostly with a specific chart in Strava Analysis). CleanShot.2024-06-19.at.15.01.16.2.mp4Have to run out the door now though. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
For any Threlte users coming here, there is a |
https://github.com/mattjennings/svelte-modals breaks because this line always evaluates to |
Components no longer being classes is an official breaking change, and Svelte can do nothing here. |
next.174 broke svelte material ui (SMUI) by @hperrin |
Just seen this - I took a quick look and it seems as though the key block with |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
In my case with svelte@5.0.0-next.202 html elements set with UPD: this is with https://github.com/romkor/svelte-portal library, without using portal it works fine. Looks like |
Please open a separate issue with a reproduction for this |
First: great work on Svelte 5, I'm looking forward to the release 👍 I'm working on upgrading Most important is that the Rollup bundling (for use of the library in a vanilla environment) is broken and Rollup warns about circular references in the svelte code being compiled. Help with the Rollup issues would be great. Besides that, there are some styling issues and event handlers that are broken now, I can probably get that fixed that myself. |
I guess svelte-5 is close to its release. There are only 8 issues left. I have started working towards upgrading svelte-commerce to svelte5 |
Shadcn-svelte Combobox works in Svelte 4, but doesn't in Svelte 5. Tried with both, the code is same in both, the only different is svelte version. I've created a repo for the same. The svelte 4 works well, svelte 5 fails - keeps adding new items when trying to filter lists https://github.com/memestageceo/combobox-4v5.git PS: Posting it here as I think that Svelte 5 is meant to be backward compatible, but in this case, it isn't. I don't know how to figure this out more than this, so kindly clone the repo and test it out. I've set up everything for both svelte 4 and svelte 5. |
This sounds like huntabyte/cmdk-sv#92, which isn't solveable on our end, and needs adjustment in the library. |
vercel/ai with the Svelte 5: Runes modeSvelte 5: Compatibility mode |
The underlying problem is that the dependency |
Describe the bug
Some libraries don't work with Svelte 5 out of the box. It will probably be impossible to make every library compatible given that some use stuff
svelte/internal
(which they really shouldn't) and everything in there changed, but those who don't should be closely investigated. Feel free to post libraries you found that don't work in here, ideally along with a small reproduction (repro or "install and use component X").Won't / can't fix
svelte/internal
in a way that can't be backported Svelte 5 support: ERROR: No matching export in "a" for import "b" TanStack/table#5213 - but a new version of the library is underway with Svelte 5 support!beforeUpdate
, the dependency likely needs to be switched out for something else Svelte 5 Support vercel/ai#3107Fixed
svelte-confetti
svelte-range-slider-pips
(through fix: better interop of$state
with actions/$:
statements #10543)Reproduction
Use the libraries and observe errors
Logs
No response
System Info
Severity
annoyance
The text was updated successfully, but these errors were encountered: