Merge pull request #262 from PaulBGD/svg-set-xmlns

xmlns should be added as an attribute for consistency
sveltejs · Jan 25, 2017 · 6cde8ff · 6cde8ff
2 parents 8eb540d + d47fead
commit 6cde8ff
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/generators/dom/visitors/attributes/addElementAttributes.js b/src/generators/dom/visitors/attributes/addElementAttributes.js
@@ -64,15 +64,21 @@ export default function addElementAttributes ( generator, node, local ) {
 					// static attributes
 					result = JSON.stringify( value.data );
 
+					let addAttribute = false;
 					if ( name === 'xmlns' ) {
 						// special case
 						// TODO this attribute must be static – enforce at compile time
 						local.namespace = value.data;
+						addAttribute = true;
 					} else if ( propertyName ) {
 						local.init.addLine(
 							`${local.name}.${propertyName} = ${result};`
 						);
 					} else {
+						addAttribute = true;
+					}
+
+					if ( addAttribute ) {
 						generator.uses[ helper ] = true;
 						local.init.addLine(
 							`${helper}( ${local.name}, '${name}', ${result} );`

diff --git a/test/generator/svg-xmlns/_config.js b/test/generator/svg-xmlns/_config.js
@@ -6,7 +6,7 @@ export default {
 		height: 100
 	},
 
-	html: `<svg><rect x="0" y="0" width="100" height="100"></rect></svg>`,
+	html: `<svg xmlns="http://www.w3.org/2000/svg"><rect x="0" y="0" width="100" height="100"></rect></svg>`,
 
 	test ( assert, component, target ) {
 		const svg = target.querySelector( 'svg' );
@@ -16,6 +16,6 @@ export default {
 		assert.equal( rect.namespaceURI, 'http://www.w3.org/2000/svg' );
 
 		component.set({ width: 150, height: 50 });
-		assert.equal( target.innerHTML, `<svg><rect x="0" y="0" width="150" height="50"></rect></svg>` );
+		assert.equal( target.innerHTML, `<svg xmlns="http://www.w3.org/2000/svg"><rect x="0" y="0" width="150" height="50"></rect></svg>` );
 	}
 };