Merge pull request #225 from sveltejs/gh-224

provide useful feedback on encountering void element closing tag
sveltejs · Dec 24, 2016 · 620b9ae · 620b9ae
2 parents 91551b9 + fc977a2
commit 620b9ae
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 0 deletions.
diff --git a/src/parse/state/tag.js b/src/parse/state/tag.js
@@ -47,6 +47,10 @@ export default function tag ( parser ) {
 	parser.allowWhitespace();
 
 	if ( isClosingTag ) {
+		if ( voidElementNames.test( name ) ) {
+			parser.error( `<${name}> is a void element and cannot have children, or a closing tag`, start );
+		}
+
 		if ( !parser.eat( '>' ) ) parser.error( `Expected '>'` );
 
 		const element = parser.current();

diff --git a/test/parser/error-void-closing/error.json b/test/parser/error-void-closing/error.json
@@ -0,0 +1,8 @@
+{
+	"message": "<input> is a void element and cannot have children, or a closing tag",
+	"loc": {
+		"line": 1,
+		"column": 23
+	},
+	"pos": 23
+}
diff --git a/test/parser/error-void-closing/input.html b/test/parser/error-void-closing/input.html
@@ -0,0 +1 @@
+<input>this is illegal!</input>