Merge pull request #851 from sveltejs/gh-850

use anchor.parentNode as target instead of slot document fragment

src/generators/dom/visitors/IfBlock.ts

@@ -152,7 +152,7 @@ function simple(
 		`if (${name}) ${name}.${mountOrIntro}(${targetNode}, ${anchorNode});`
 	);
 
-	const parentNode = (state.parentNode && !needsAnchor) ? state.parentNode : `${anchor}.parentNode`;
+	const parentNode = isDomNode(node.parent, generator) ? node.parent.var : `${anchor}.parentNode`;
 
 	const enter = dynamic
 		? branch.hasIntroMethod
@@ -255,7 +255,7 @@ function compound(
 		`${if_name}${name}.${mountOrIntro}(${targetNode}, ${anchorNode});`
 	);
 
-	const parentNode = (state.parentNode && !needsAnchor) ? state.parentNode : `${anchor}.parentNode`;
+	const parentNode = isDomNode(node.parent, generator) ? node.parent.var : `${anchor}.parentNode`;
 
 	const changeBlock = deindent`
 		${hasElse

test/runtime/samples/component-slot-if-block-before-node/Nested.html

@@ -0,0 +1,3 @@
+<div>
+	<slot/>
+</div>

test/runtime/samples/component-slot-if-block-before-node/_config.js

@@ -0,0 +1,16 @@
+export default {
+	html: `
+		<div>
+			<p>unconditional</p>
+		</div>`,
+
+	test(assert, component, target) {
+		component.set({ foo: true });
+		assert.htmlEqual(target.innerHTML, `
+			<div>
+				<p>conditional</p>
+				<p>unconditional</p>
+			</div>
+		`);
+	}
+};

test/runtime/samples/component-slot-if-block-before-node/main.html

@@ -0,0 +1,17 @@
+<Nested>
+	{{#if foo}}
+		<p>conditional</p>
+	{{/if}}
+
+	<p>unconditional</p>
+</Nested>
+
+<script>
+	import Nested from './Nested.html';
+
+	export default {
+		components: {
+			Nested
+		}
+	};
+</script>

test/runtime/samples/component-slot-if-else-block-before-node/Nested.html

@@ -0,0 +1 @@
+<slot/>

test/runtime/samples/component-slot-if-else-block-before-node/_config.js

@@ -0,0 +1,13 @@
+export default {
+	html: `
+		<p>disabled</p>
+		<p>unconditional</p>`,
+
+	test(assert, component, target) {
+		component.set({ enabled: true });
+		assert.htmlEqual(target.innerHTML, `
+			<p>enabled</p>
+			<p>unconditional</p>
+		`);
+	}
+};

test/runtime/samples/component-slot-if-else-block-before-node/main.html

@@ -0,0 +1,19 @@
+<Nested>
+	{{#if !enabled}}
+		<p>disabled</p>
+	{{else}}
+		<p>enabled</p>
+	{{/if}}
+
+	<p>unconditional</p>
+</Nested>
+
+<script>
+	import Nested from './Nested.html';
+
+	export default {
+		components: {
+			Nested
+		}
+	};
+</script>