Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update broken documentation example #650

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

IanGallacher
Copy link
Contributor

@IanGallacher IanGallacher commented Jul 28, 2024

Updates documentation example to correctly use changes from PR #641

PR #641 change the example to have import { sveltePreprocess } from 'svelte-preprocess' instead of import preprocess from 'svelte-preprocess', but missed one spot where preprocess needed to change to sveltePreprocess.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to run pnpm lint!)

Tests

  • Run the tests with npm test or pnpm test

update documentation example to correctly use changes from PR sveltejs#641
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 359b1f6 into sveltejs:main Jul 28, 2024
@IanGallacher IanGallacher deleted the smallReadmeFix branch July 28, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants