Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: change es6 import to cjs require #267

Merged
merged 1 commit into from
Oct 6, 2020
Merged

docs: change es6 import to cjs require #267

merged 1 commit into from
Oct 6, 2020

Conversation

ignatiusmb
Copy link
Member

Fixes sveltejs/language-tools#593 causing error sveltejs/language-tools#593 (comment)

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR relates to an outstanding issue, so please reference it in your PR, or create an explanatory one for discussion. In many cases features are absent for a reason.
  • This message body should clearly illustrate what problems it solves. If there are related issues, remember to reference them.
  • Ideally, include a test that fails without this PR but passes with it. PRs will only be merged once they pass CI. (Remember to npm run lint!)

Tests

  • Run the tests with npm test or yarn test

Copy link
Member

@kaisermann kaisermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, nice!

@kaisermann kaisermann merged commit e5fd816 into sveltejs:master Oct 6, 2020
@kaisermann kaisermann self-assigned this Oct 6, 2020
@ignatiusmb ignatiusmb deleted the docs/fix-svelte-config branch October 6, 2020 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not respect default language in svelte.config.js
3 participants