-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about node version requirement #71
Conversation
We specified Node 14 in the |
I think as of a while ago npm by default won't refuse to install when the So, in particular, I do get a message from npm on Node 12 currently, but I also get a bunch of other messages. I don't know what the correct answer is here. If we do want to explicitly document this somewhere, I think it should be somewhere more visible than a C-style comment in a block of commands to be executed in the terminal. |
@@ -80,6 +80,7 @@ | |||
|
|||
<div slot="how"> | |||
<pre><code> | |||
// You'll need Node.js v14 or higher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't JS so should use bash-style commenting
// You'll need Node.js v14 or higher | |
# You'll need Node.js v14 or higher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aah right, fixed now.
Add note about node version requirement Bash style comment Muted and italicized comment
Wouldn't it be the most visible here since this is where most people will learn the installation process for the first time? |
The fact that |
I'm going to close this in favor of the SvelteKit bug. If we decide we can't fix the SvelteKit bug for some reason then we can revisit this |
The
Unexpected token '.'
error has appeared quite a few times on discord and recently on the Kit issue tracker as well. Older node.js doesn't support optional chaining so starting the dev server fails with no changes to the starter template whatsoever. It isn't a great experience for new people if they have to go hunting for the fix.I posted a screenshot on discord, that one had an extra line in it, but that should be fixed now, and it actually looks decent without the huge gap.