fix: clarify error message #526
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gtm-nayan
force-pushed
the
clearer-error-message
branch
from
638869e
to
ecd34cb
Compare
PuruVJ
reviewed
Jul 10, 2023
| @@ -286,8 +286,7 @@ async function get_bundle(uid, mode, cache, local_files_lookup) { | |||
| if (importer && local_files_lookup.has(importer)) { | |||
| // relative import in a REPL file | |||
| // should've matched above otherwise importee doesn't exist | |||
| console.error(`Cannot find file "${importee}" imported by "${importer}" in the REPL`); | |||
| return; | |||
| throw new Error(`Cannot find file "${importee}" imported by "${importer}" in the REPL`); | |||
There was a problem hiding this comment.
I remember I did it because the compiler was hanging fully on any error and refusing to re-run on typing. lemme check if this works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without throwing, the error is only logged to the console and the banner shows another confusing error.