Don't remove the outline on focus #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wolfr <johan.ronsse@gmail.com>
Signed-off-by: Wolfr <johan.ronsse@gmail.com>
antony
approved these changes
Apr 11, 2020
|
Yeah, pretty sure this is my bad — thanks for the fix. I think it's worth hiding the outline on mouse interactions but leaving them for keyboard interactions (which is the browser default behaviour, it just breaks as soon as you add any button CSS at all), but that should be a separate issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to navigate with the keyboard, you need focus styles. Removing focus styles while not providing an alternative is not good for accessibility.
Signed-off-by: Wolfr johan.ronsse@gmail.com