Allow building Sapper on Windows

[benmccann]

Someone reported on Discord that they can't build Sapper because rm -rf doesn't work

How is anything passing on the Windows build without this?

sapper/.github/workflows/ci.yml

Line 9 in 7af69e9

os: [ubuntu-latest, windows-latest, macOS-latest]

[hanschua]

It seems that the Windows runners includes the Git bash in the path by default. actions/runner-images#30 (comment)

The script adding the Git bash to the path is at https://github.com/actions/virtual-environments/blob/main/images/win/scripts/Installers/Install-Git.ps1#L41

[Conduitry]

It looks like the rebase lost actually using rimraf for these deletions.

[benmccann]

oops. fixed!

[Conduitry]

Can we use rimraf@2, which is already a transitive dependency, rather than adding a new dependency and making npm install several additional copies of rimraf@2?

[Conduitry]

Eh. Maybe that doesn't matter so much.

$ npm ls rimraf
sapper@0.28.8 /home/conv/dev/sveltejs/sapper
├─┬ eslint@7.6.0
│ └─┬ file-entry-cache@5.0.1
│   └─┬ flat-cache@2.0.1
│     └── rimraf@2.6.3
├─┬ puppeteer@5.2.1
│ └── rimraf@3.0.2
└─┬ webpack@4.44.1
  └─┬ terser-webpack-plugin@1.4.5
    └─┬ cacache@12.0.4
      ├─┬ move-concurrently@1.0.1
      │ ├─┬ copy-concurrently@1.0.5
      │ │ └── rimraf@2.6.3  deduped
      │ └── rimraf@2.6.3  deduped
      └── rimraf@2.6.3  deduped

We already have v3 via Puppeteer.