(fix) fall back to FormattingOptions #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case no prettier configs are found sveltejs#539 BREAKING CHANGE: If user has no prettier config, he now gets the tab size / space/tabs-settings of his IDE, not the default prettier config
|
I'm also in favor of it. By default |
jasonlyu123
reviewed
Sep 22, 2020
jasonlyu123
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case no prettier configs are found
#539
@jasonlyu123 what do you think? Is this change a change we want to make? It's a breaking change and might be confusing. On the other hand it's also confusing right now that your user settings are not used if you don't know of prettier. So I'm in favor of it.
Situation:
User does not have any prettier config (either through
.prettierrcor through VSCode settings)Before:
Prettier defaults of tabWidth and useTabs are used
After:
The FormattingOptions in the format request are used. These are usually the tabSize/insertSpaces editor settings.