Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance diagnostics #510

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Conversation

dummdidumm
Copy link
Member

Make it more clear what the cannot be used as a JSX component error is about.

@jasonlyu123 could you have a look and tell me if the error message is understandable?

Make it more clear what the `cannot be used as a JSX component` error is about.
@jasonlyu123
Copy link
Member

jasonlyu123 commented Aug 31, 2020

The message is ok! but maybe add a simple example of $$props_def?

Copy link
Member

@jasonlyu123 jasonlyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dummdidumm dummdidumm merged commit 638b295 into sveltejs:master Aug 31, 2020
@dummdidumm dummdidumm deleted the enhance-diagnostics branch August 31, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants