Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always include source map in ts-preprocess of internal svelte compile #495

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

jasonlyu123
Copy link
Member

@jasonlyu123 jasonlyu123 commented Aug 28, 2020

svelte-preprocess merge the compilerOption with the parsed config file
https://github.com/sveltejs/svelte-preprocess/blob/36d6421db847f8886ebad4c0e8c77671a9a4e3f9/src/transformers/typescript.ts#L69
So it won't override other user-defined configs. Although the problem mentioned here #489 (comment) here still exists, this would at least make the set up a little bit easier.

@jasonlyu123 jasonlyu123 changed the title alway include source map in ts-preprocess of internal svelte compile always include source map in ts-preprocess of internal svelte compile Aug 28, 2020
@dummdidumm
Copy link
Member

This will only fix errors for people who do not have a svelte.config.js inside their workspace, because it's only a fallback. But as you say, in these cases it will make setup easier 😄

@dummdidumm dummdidumm merged commit 651814a into sveltejs:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants