fix: Added missing event handlers #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfanger
force-pushed
the
feature/event-handlers
branch
2 times, most recently
from
1d4a360
to
25d248c
Compare
jasonlyu123
requested changes
Jul 31, 2020
|
Hmm, my editor formatted causing conficts, i'll clean up the commits, one moment.. |
- Removed *capture - Synced knownevents.ts
bfanger
force-pushed
the
feature/event-handlers
branch
from
4c25f85
to
c8beca4
Compare
|
Done, removed (and tested) the unnecessary on*capture event handlers, also synced the knownevents.ts and added onfullscreenchange & onfullscreenerror (I checked all events on div element) |
dummdidumm
requested changes
Jul 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event handlers that are working, like
<svelte:window on:hashchange={handler} />are triggering typescript errors:I've extracted the available events from Chrome with:
JSON.stringify(Object.keys(window).filter(k=>k.substr(0,2) ==='on'))and removed events that didn't have a type likeWindow['onsearch']or are deprecated/non-standard likeonmousewheel