Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix style svg attribute #346

Closed
wants to merge 1 commit into from
Closed

fix style svg attribute #346

wants to merge 1 commit into from

Conversation

galkatz373
Copy link
Contributor

Fixes #345
I changed the style attribute for svg element from CSSProperties to string | CSSProperties, as HTMLAttributes interface.

@jasonlyu123
Copy link
Member

I think we can remove CSSProperties. It doesn't work. But we can leave the interface there, doesn't hurt.
https://svelte.dev/repl/84c05f0e49104782ae8998dde51b906a?version=3.24.0

@galkatz373 galkatz373 closed this Jul 24, 2020
@galkatz373 galkatz373 deleted the fix-style-svg branch July 24, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte-check complaints against type of correct style attribute on SVG elements
2 participants