Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) support default language of svelte-preprocess #291

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

dummdidumm
Copy link
Member

svelte-preprocess has a feature for setting default languages so you don't have to write lang="x" each time. This adds support for this in style/script tags.

To accomplish this, parsing of the svelte.config.js was moved up to Document. Inside it, the lang attribute is set to the default language if there exists no lang/type attribute.

I deliberately did not bump the svelte-preprocess version yet to wait until 4.x has received some more feedback and bugfixes.

`svelte-preprocess` has a feature for setting default languages so you don't have to write `lang="x"` each time. This adds support for this in style/script tags.

To accomplish this, parsing of the `svelte.config.js` was moved up to `Document`. Inside it, the `lang` attribute is set to the default language if there exists no `lang`/`type` attribute.
@dummdidumm
Copy link
Member Author

dummdidumm commented Jul 8, 2020

I did not change any dependencies and now build fails due to dependency errors... ? oO

@dummdidumm dummdidumm merged commit 08f2e69 into sveltejs:master Jul 8, 2020
@dummdidumm dummdidumm deleted the default-language branch July 8, 2020 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant