fix: allow autoImportFileExcludePatterns to ignore files outside the root #2480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
reviewed
Aug 30, 2024
| getTsUserPreferences(lang: TsUserConfigLang, workspacePath: string | null): ts.UserPreferences { | ||
| getTsUserPreferences( | ||
| lang: TsUserConfigLang, | ||
| normalizedWorkspacePath: string | null |
There was a problem hiding this comment.
you changed the name here - just for readability, or is there a corresponding normalization missing in another file?
There was a problem hiding this comment.
Just readability because there is a string concatenation for the pattern. It's already normalized since it's from urlToPath the same as what we did in normalizePath.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first part of #2479. I will probably open a separate PR to deprioritise the component auto-import later. I did try it before and it should be possible to detect if there is a barrel import in the same list.