(fix) register OnEnter rules (#236) #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All the lint errors seem to be related to the very long regex used in the OnEnter rules. Should I make eslint ignore those errors or attempt to fix it somehow? |
|
hah, yeah, I'd make eslint disable the line completely |
|
Thanks for the PR! Could you for each regex add a short comment roughly explaining what it does? |
|
@dummdidumm I actually copied it mostly verbatim from https://github.com/microsoft/vscode/blob/master/extensions/html-language-features/client/src/htmlClient.ts#L209-L226 Should I write a short comment explaining how I understand it? |
|
That would be great! |
|
@dummdidumm @orta Done |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Register OnEnter rules for proper auto indenting. Fixes #236