update all opened document diagnostics on save #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
requested changes
Jun 28, 2020
There was a problem hiding this comment.
If I understand correctly you want to track what is really opened in the IDE and not what was opened by for example the ts language service as part of resolving file references. If yes, I would refactor it so that this is more explicit, so that in connection.onDidOpenTextDocument there is a docManager.markAsOpenedInClient(evt.textDocument.uri) and in connection.onDidCloseTextDocument add docManager.markAsClosedInClient(evt.textDocument.uri). Inside DocumentManager this is tracked as a set of openedDocsInClient, which the DiagnosticsManager uses.
Apart from that it looks good 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #177
update the diagnostics of all opened svelte files when a svelte file or js file is saved to disk. Mainly for typescript type errors.