chore: try fix flaky test #2203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/sveltejs/svelte-ecosystem-ci/actions/runs/6845976020/job/18611980022
There are two files that don't exist that were referenced in the test. We must rely on
openClientDocumentto open them. But It seems like there is a race condition somewhere that would close it after it's opened. I'm not really sure if this is the case since I can't reproduce it locally even if I run it at least 100 times.If the file does exist, it'll be loaded as a project file the first time the ts service is created. And the
openClientDocumentwill only be used as a failed safe. Hopefully, it will fix the problem. I also added a new test to test the language feature of the client file that doesn't exist in the file system. It's tested in a virtual system, so it should be more isolated and less likely to fail randomly.