Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase test timeout for riscv64 #2200

Closed
wants to merge 1 commit into from
Closed

test: increase test timeout for riscv64 #2200

wants to merge 1 commit into from

Conversation

phanen
Copy link
Contributor

@phanen phanen commented Nov 12, 2023

Some tests fails on slow RISC-V architecture.
Fix by increasing the timeout.

@jasonlyu123
Copy link
Member

We discussed this before and want to avoid increasing the timeout to catch potential performance problems. Which test failed because of time out in your environment? We'd prefer to separate out the demanding part into a warm-up step instead of picking a random number on all tests. If it's not possible, I'd prefer you add a utility function that takes an environmental variable or a command line flag so you can increase it by yourself.

@phanen
Copy link
Contributor Author

phanen commented Nov 17, 2023

Thanks for advices. I can use command flags pnpm test -- --timeout 100000 to pass all tests with default timeout. But most tests with override hardcode may fail (like serviceWarmup and performance test..).

I've opened a new pr (#2205) to make it possible to handle all tests using cli only.

@phanen phanen closed this Nov 17, 2023
@phanen phanen deleted the test/increase-timeout branch November 17, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants