Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) manual define svelteSys.readFile for compatibility #2142

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

jasonlyu123
Copy link
Member

#2138

Imba typescript plugin patch this with Object.defineProperty and copy the property descriptor from a class that extends the original ts.sys. So, we explicitly define it here. Although it makes more sense to fix it on their side It's more productive for us to define it than arguing with them in an issue.

@jasonlyu123 jasonlyu123 merged commit f35d311 into sveltejs:master Aug 27, 2023
2 checks passed
@jasonlyu123 jasonlyu123 deleted the svelteSys-read-file branch August 27, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants