fix: inlay hint position sometimes off by one #2079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BlueGreenMagick
force-pushed
the
fix-inlay-hint-position
branch
2 times, most recently
from
1ae0b4d
to
8566c2b
Compare
BlueGreenMagick
force-pushed
the
fix-inlay-hint-position
branch
from
8566c2b
to
aadaf85
Compare
|
Fixed lint |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued from PR #2070
Fixes issue #1988
Inlay hint position is sometimes off by 1 as mentioned in #2070
This code detects if inlay hint position is off by 1 by checking
source[position]. It is off by one ifkind == InlayHintKind.Type, andsource[position]is not a valid character that comes after an identifier.A valid character that can come after an identifier, is ascii characters that is not alphanumeric A-Z(x41-x5A), a-z(x61-x7A), 0-9(x30-x39), or special characters '$'(x24), '_'(x5F), '\'(x5C).