Svelte-ignore code action #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think there's still some code action range issue needed needed to be considered. Also check if it affects script and style. |
jasonlyu123
commented
Jun 7, 2020
There was a problem hiding this comment.
Also needed to change it to parsing the transpiled code if exists.
Ultimately the AST should be managed separately so that it could be used in other places like #169
packages/language-server/src/plugins/svelte/features/getCodeActions.ts
Outdated
Show resolved
Hide resolved
|
Nice work! I added a mapping from generated to original, so it also works when you use preprocessors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #122
Only the Diagnostics where the source is svelte and it has diagnostics code can be able to be ignored.
Maybe should also still check all the warning in the svelte compiler to see if any of it should be filtered out.