Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode rename extension setting #640

Closed
quoid opened this issue Oct 29, 2020 · 3 comments
Closed

VSCode rename extension setting #640

quoid opened this issue Oct 29, 2020 · 3 comments
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.

Comments

@quoid
Copy link

quoid commented Oct 29, 2020

I am trying to prevent, at least temporarily, the vscode extension from changing my imports when I move a file. From reading the documentation, I assumed the option to do this would be svelte.plugin.svelte.rename.enable.

However, that option doesn't seem to have any effect on the behavior. It's also not present in the extension settings ui on version v102.3.0.

Is there a way to disable the plugin from changing code when files are moved and is the above mentioned setting functional at the moment?

@dummdidumm
Copy link
Member

Strange, it should adhere to this setting (see this code line). Which files are affected by that? If it's files other than Svelte files, it's likely the TS language server integrated into VS Code which does this.

@quoid
Copy link
Author

quoid commented Oct 29, 2020

I am working with .svelte files. Just to be sure, this is the setting I'd want to disable if I'd like to stop my imports getting auto corrected when moving files around, correct?

It's very possible I am missing something, but shouldn't the setting be "exposed" to the user through the settings ui? It's also coming up as an unused config setting in my workspace settings file.

Screen Shot 2020-10-29 at 09 26 37

@dummdidumm
Copy link
Member

This indeed is a bug, thanks for bringing it up.

@dummdidumm dummdidumm added the bug Something isn't working label Oct 29, 2020
dummdidumm pushed a commit to dummdidumm/language-tools that referenced this issue Oct 29, 2020
Add typescript.rename.enable and svelte.rename.enable
sveltejs#640
dummdidumm added a commit that referenced this issue Oct 29, 2020
Add typescript.rename.enable and svelte.rename.enable
#640
@dummdidumm dummdidumm added the Fixed Fixed in master branch. Pending production release. label Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Fixed in master branch. Pending production release.
Projects
None yet
Development

No branches or pull requests

2 participants