organize-imports does not work when there is a module script block #221
Comments
dummdidumm
pushed a commit
to dummdidumm/language-tools
that referenced
this issue
Aug 14, 2020
sveltejs#221 ``` <script context="module"> import {c} from './c'; </script> <script lang="ts"> import B from './B'; import A from './A'; </script> <A>{c}</A> ``` ----> ``` <script context="module"> import A from './A'; import { c } from './c'; // do whatever </script> <script lang="ts"> </script> <A>{c}</A> ```
dummdidumm
added a commit
that referenced
this issue
Aug 14, 2020
#221 ``` <script context="module"> import {c} from './c'; </script> <script lang="ts"> import B from './B'; import A from './A'; </script> <A>{c}</A> ``` ----> ``` <script context="module"> import A from './A'; import { c } from './c'; </script> <script lang="ts"> </script> <A>{c}</A> ```
|
I think the fix in #454 is not the best option. When using functions - that are imported in the module script block - in reactive statements, svelte warns that the function is not reactive. The imports should stay in the script block in which they are defined, the imports should be sorted independent from each other. I know the functions will not be reactive when imported in the regular script block, but the warning would be gone |
|
This sounds more like inconsistent behavior in Svelte itself. Svelte should throw the warning in both cases since it's an import. |
|
You are right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
organize-imports does not work when there is a
<script context="module">blockTo Reproduce
Expected behavior
Imports should be organized in both
scriptblocks.The text was updated successfully, but these errors were encountered: