Inconsistent Props completion in namespaced component

[huntabyte]

Describe the bug

I'm noticing that the autocomplete works only if a known prop comes before you attempt to trigger Intellisense.

Here's an example of trying to trigger Intellisense before the prop:

Then if you try to trigger Intellisense after the prop, the correct result is displayed:

But if you try to use an expression, it also breaks:

Without the expression, all good:

Reproduction

Create a component:

<!-- button.svelte -->
<script lang="ts">
	export let label = "Open menu"
	export let disabled = false
</script>

<button {disabled} aria-label={name}>
	<slot />
</button>

Export it

// index.ts
import Root from './button.svelte'
export { Root }

Attempt to get Intellisense to work when using it:

<script lang="ts">
	import * as Button from '$lib'
</script>

<Button.Root >
	Open
</Button.Root>

Expected behaviour

Once a space has been inserted after the .Root, Intellisense should display the props.

System Info

• OS: MacOS
• IDE: VSCode

Which package is the issue about?

No response

Additional Information, eg. Screenshots

No response

[AdrianGonz97]

I'd like to add some additional quirks that I've found:

This issue doesn't occur for namespaced components that are self-closing:

If you don't manually trigger the auto completion prompt (CTRL + SPACE) and instead just add the first letter of a prop, you'll get the proper prop completions for the component:

[AdrianGonz97]

Thanks for the fix @jasonlyu123, it's very much appreciated! 😄 I cloned this repo to test out the changes and noticed 1 issue.

The prop completions don't show correctly when you trigger them when you're 1 space out. It seems like it only triggers when you're two spaces out, as shown here:

With that in mind, I've tested out all of the scenarios where it previously didn't work and they all seem to work now!

Edit:
I reverted back to the older version of the svelte extension and the 2 space trigger to get the correct completions characteristic is present there too 🤔 In that respect, I'm not sure if anything has really changed

Here's a reproduction to demonstrate the cases where it does and does not work: https://github.com/AdrianGonz97/inconsistent-namespace-props-repro

[jasonlyu123]

I can't reproduce it with the reproduction. Are you sure the build succeeded? Or maybe you have the svelte.language-server.ls-path config? Or maybe tsc incremental build glitched? I did encounter this when I pulled the commit. But worked after I forced tsc to do a clean build.

[AdrianGonz97]

@jasonlyu123 Aha, you're correct! After deleting the my local repo and recloning, building and testing again, it seems to be working now. Sorry about that!!

Everything looks to be working beautifully. 😄 Thanks for the help!