-
-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap to new transformation #1552
Comments
I'm afraid I haven't been actively working on Svelte NodeGUI for over a year now, and it never received a great amount of usage, so I probably won't be getting too involved with this! But I have added what feedback I can to #7649. Thank you very much for keeping custom renderers in mind, though! Broadly speaking, the main issue with custom renderers (beside naming of event handlers, as I've described) up until now has been that when you assign |
New transformation works a little different and requires the added functions to be available under the namespace. Ref: sveltejs/language-tools#1552
The new transformation which transforms Svelte to TS code instead of TSX code for intellisense purposes has been in beta for a while now, and I think it's stable enough to switch to it. This is a breaking change which needs some coordination, so I'm writing down the steps here:
href
ona
tags. At the same time we want to minimize the reliance onsvelte2tsx
. Therefore we need these transformation in Svelte core. [feat] add html typings svelte#7649 adds these. Also (feat) enable actions to enhance typings on applied element #1553 for better action typings. (Update: Not merging the HTML PR for now)svelte2tsx
on:X
events). Depending on the outcome it may be better to bury our hopes of doingon:X
event typings and instead keeponX
typings.svelte-jsx.d.ts
so that the old typings are removed - only keep some of the interfaces that people might have used to enhance their typings. Add the typing mentioned in (fix) keep colon while transforming events #1549 so breakage on events is minimal for peolesvelte-check
3.0 with the new transformation only. This requires peer dependency bumps for Svelte and TypeScript. We should also bump the node version to latest 14 so we can bump the LSP version under the hood later without it being another breaking change@jasonlyu123 what do you think about these steps? Did I miss anything?
The text was updated successfully, but these errors were encountered: