(fix) don't do any diagnostics for node_module files (#1174)

Previously, only TS diagnostics were omitted #1056
sveltejs · Sep 13, 2021 · 6f3df5f · 6f3df5f
1 parent 2f56361
commit 6f3df5f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 14 deletions.
diff --git a/packages/language-server/src/plugins/PluginHost.ts b/packages/language-server/src/plugins/PluginHost.ts
@@ -75,6 +75,20 @@ export class PluginHost implements LSProvider, OnWatchFileChanges {
             throw new Error('Cannot call methods on an unopened document');
         }
 
+        if (
+            (document.getFilePath()?.includes('/node_modules/') ||
+                document.getFilePath()?.includes('\\node_modules\\')) &&
+            // Sapper convention: Put stuff inside node_modules below src
+            !(
+                document.getFilePath()?.includes('/src/node_modules/') ||
+                document.getFilePath()?.includes('\\src\\node_modules\\')
+            )
+        ) {
+            // Don't return diagnostics for files inside node_modules. These are considered read-only (cannot be changed)
+            // and in case of svelte-check they would pollute/skew the output
+            return [];
+        }
+
         return flatten(
             await this.execute<Diagnostic[]>(
                 'getDiagnostics',

diff --git a/packages/language-server/src/plugins/typescript/features/DiagnosticsProvider.ts b/packages/language-server/src/plugins/typescript/features/DiagnosticsProvider.ts
@@ -15,20 +15,6 @@ export class DiagnosticsProviderImpl implements DiagnosticsProvider {
         document: Document,
         cancellationToken?: CancellationToken
     ): Promise<Diagnostic[]> {
-        if (
-            (document.getFilePath()?.includes('/node_modules/') ||
-                document.getFilePath()?.includes('\\node_modules\\')) &&
-            // Sapper convention: Put stuff inside node_modules below src
-            !(
-                document.getFilePath()?.includes('/src/node_modules/') ||
-                document.getFilePath()?.includes('\\src\\node_modules\\')
-            )
-        ) {
-            // Don't return diagnostics for files inside node_modules. These are considered read-only (cannot be changed)
-            // and in case of svelte-check they would pollute/skew the output
-            return [];
-        }
-
         const { lang, tsDoc } = await this.getLSAndTSDoc(document);
 
         if (