chore: uvu -> vitest for create-svelte tests #9910

gtm-nayan · 2023-05-11T23:09:19Z

This is a follow on to #9899

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
This message body should clearly illustrate what problems it solves.
Ideally, include a test that fails without this PR but passes with it.

Tests

Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

changeset-bot · 2023-05-11T23:09:22Z

⚠️ No Changeset found

Latest commit: b36ad22

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

benmccann · 2023-05-13T20:56:34Z

@gtm-nayan thanks for this! I didn't see it was targeting my PR until just now. I already merged the larger PR. Think you could target this against a rebased master?

benmccann · 2023-05-13T22:21:22Z

Thanks @gtm-nayan! It looks like lint is failing

benmccann · 2023-05-14T03:57:43Z

packages/create-svelte/test/check.js

+	60000
+);
+
+function patch_package_json(pkg) {


it might be nice to pass in overrides vs depending on a global variable. would also need to tweak where it's being called then

Suggested change

function patch_package_json(pkg) {

function patch_package_json(pkg, overrides) {

but they are global, or rather shared by everything in the module. not sure what this would achieve — overrides would still be defined/populated at the module level, we'd just be replacing a closed-over value with an identical parameter, no?

yes. I just think it's a bit cleaner to avoid depending on global values - e.g. if you wanted to have a unit test for the method it's easier that way. no functional difference though and just a matter of opinion

benmccann · 2023-05-14T04:05:29Z

packages/kit/src/runtime/server/cookie.spec.js

@@ -174,10 +174,10 @@ test('warns if cookie exceeds 4,129 bytes', () => {
 		const error = /** @type {Error} */ (e);

 		assert.equal(error.message, `Cookie "a" is too large, and will be discarded by the browser`);
+	} finally {
+		// @ts-expect-error
+		globalThis.__SVELTEKIT_DEV__ = false;


In kit.vitest.config.js, I put:

isolate: false, singleThread: true,

I did that to speed up the tests, but I'm realizing if we're modifying global variables like this then that's probably not safe to do, so we should probably remove them

this has its own vitest.config.js which doesn't have those settings, so it should be fine i think?

I don't think it does have its own vitest.config.js? This file is located in the kit project unlike the others

ah right. can we mark a single file as requiring isolation? probably should discuss this in a separate PR

csp.spec.js does it too, so we'd need to do it to more than one file. Those flags only save 1-2s, so maybe it's not worth using them

packages/create-svelte/test/check.js

…it correctly formatted templates

Rich-Harris · 2023-05-16T20:25:18Z

i think the test failures are related to #9919

Rich-Harris · 2023-05-16T21:17:09Z

Why is lint failing? The offending file, packages/kit/create-svelte/templates/default/src/routes/sverdle/+page.svelte, should be excluded because of the root .prettierrc.

I guess I'll just revert aa188d4 for now but I don't get why this isn't working

Rich-Harris · 2023-05-16T21:17:22Z

Why is lint failing? The offending file, packages/kit/create-svelte/templates/default/src/routes/sverdle/+page.svelte, should be excluded because of the root .prettierrc.

I guess I'll just revert aa188d4 for now but I don't get why this isn't working

…e can emit correctly formatted templates" This reverts commit aa188d4.

* feat: Add a speedier script tag for prerendered redirects (sveltejs#9911) * feat: Add a script redirect to prerendered pages * changeset * Update .changeset/hungry-rocks-hunt.md Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * fix test * feat: Update string escaping * Update .changeset/hungry-rocks-hunt.md Co-authored-by: Conduitry <git@chor.date> --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Conduitry <git@chor.date> * fix: avoid inlining raw/url CSS imports (sveltejs#9925) * fix: use transformRequest for CSS modules * just avoid raw or url * test and changeset * use parsed query * remove only * Update packages/kit/test/apps/basics/test/cross-platform/test.js * drive by test speed up * feat: prerender & analyse in worker rather than subprocess to support Deno (sveltejs#9919) * feat(fork): use workers * Create hot-actors-hope.md * Update packages/kit/src/utils/fork.js Co-authored-by: Rich Harris <hello@rich-harris.dev> --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <hello@rich-harris.dev> * avoid using isMainThread, since it interacts poorly with vitest (sveltejs#9941) Co-authored-by: Rich Harris <git@rich-harris.dev> * chore: bump vite and devalue (sveltejs#9933) * bump vite and devalue * update templates * merge master * fix test --------- Co-authored-by: Rich Harris <git@rich-harris.dev> * chore: uvu -> vitest for create-svelte tests (sveltejs#9910) * chore: uvu -> vitest for create-svelte tests * format * concurrency (sveltejs#9921) * realised we werent typechecking this file, found some errors. fixed * Wait for beforeAll hook to complete * simplify * exclude create-svelte/template files from prettier, so that we can emit correctly formatted templates * remove unused file * Revert "exclude create-svelte/template files from prettier, so that we can emit correctly formatted templates" This reverts commit aa188d4. --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> * feat: unshadow `form` and `data` in `enhance` (sveltejs#9902) * feat: Un-shadow `data` and `form` in `enhance`, warn about future deprecation in dev * changeset * snek * Update .changeset/odd-crews-own.md Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * Update packages/kit/test/apps/dev-only/package.json Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * am not smart * still not smart * oops * oof * add deprecation notice --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> * fix: Set loader: { '.wasm': 'copy' } in esbuild config in `adapter-cloudflare-workers` (sveltejs#9940) * fix: Set loader: { '.wasm': 'copy' } in esbuild config in `adapter-cloudflare-workers` Copies WASM files in Cloudflare instead of trying to load them. Related to sveltejs#9909 * Create brave-peaches-buy.md * Update packages/adapter-cloudflare-workers/index.js * format --------- Co-authored-by: Rich Harris <git@rich-harris.dev> Co-authored-by: Rich Harris <hello@rich-harris.dev> * fix: Flaky test (sveltejs#9947) * fix: Flaky test * reuse locator * add semi * drive by test speed up * another classic * oh my god brain, y u so bad --------- Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: gtmnayan <gtmnayan@gmail.com> * remove envVarsInUse (sveltejs#9942) Co-authored-by: Rich Harris <git@rich-harris.dev> * fix: type `vitePlugin` in config (sveltejs#9946) * fix: type `vitePlugin` in config * changeset * fix: Set `loader: { '.wasm': 'copy' }` in esbuild config in `adapter-vercel` (sveltejs#9944) * fix: Enable wasm copy in adapter-vercel * Create olive-rings-eat.md --------- Co-authored-by: Rich Harris <richard.a.harris@gmail.com> * feat: crawl URLs in `<meta>` tags (sveltejs#9900) * Crawl social-image urls during prerender * Formatting & Linting * Format changeset & added exhaustive list of crawlable urls * Changed severity to minor as described in sveltejs#5228 * Added support for `property` attribute & limited valid names to just social tags * More tests * Better changeset message - I'm indecisive * Update .changeset/thirty-garlics-tan.md Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * simplify * simplify * Removed redundant data-sanitation * DRY out --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> * Version Packages (sveltejs#9893) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * feat: support AWS via SST in adapter-auto (sveltejs#9874) * [feat] support AWS via SST in adapter-auto * Sync * Delete 95-adapter-aws-sst.md * Update .changeset/rotten-ducks-tan.md --------- Co-authored-by: Rich Harris <hello@rich-harris.dev> * Version Packages (sveltejs#9953) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * only cache response if response has cache-control header (sveltejs#9885) * only cache response if response has cache-control header * add changeset * Version Packages (sveltejs#9955) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * fix: ensure styles are loaded in dev mode for routes containing special characters (sveltejs#9894) * Fix loading styles for routes containing special characters in dev mode. SvelteKit doesn't decode special characters in pathnames when loading CSS modules in dev mode, resulting in an error: Internal server error: Failed to load url /src/routes/(special)/hinnap%C3%A4ring/+page.svelte?svelte=&type=style&lang.css=&inline= (resolved id: /src/routes/(special)/hinnap%C3%A4ring/+page.svelte?svelte&type=style&lang.css). Does the file exist? Actual path: /src/routes/(special)/hinnapäring/ Fix by using decodeURI on the url.pathname when loading CSS modules. * Create stale-houses-yell.md * decodeURL inside if * add test --------- Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> * feat: Warn users when submitting forms with files but no `enctype="multipart/form-data"` (sveltejs#9888) * fix: Package name keeps me from filtering with pnpm * feat: Warn users when submitting a form containing a file without the correct enctype * changeset * Update packages/kit/src/runtime/app/forms.js Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> * style * moar style tweaks * better test skip * Update .changeset/tasty-llamas-relate.md Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> * DRY out * only warn once per submit * Update .changeset/tasty-llamas-relate.md Co-authored-by: Rich Harris <richard.a.harris@gmail.com> --------- Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <git@rich-harris.dev> Co-authored-by: Rich Harris <richard.a.harris@gmail.com> * Version Packages (sveltejs#9957) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * security: Stop automatically adding URLs from server-side `load` `fetch` calls to dependencies (sveltejs#9945) * feat: Add `dangerZone` config * breaking: Don't implicitly track deps in server-side fetch * changeset * bein dumb * fix: Server load invalidation * fix: Write config for server * fix: test * unsurprisingly i am dumb * docs: Clarify difference between server `fetch` and universal `fetch` * tests * rename to trackServerFetches --------- Co-authored-by: Rich Harris <git@rich-harris.dev> * Version Packages (sveltejs#9963) Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: S. Elliott Johnson <sejohnson@torchcloudconsulting.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Conduitry <git@chor.date> Co-authored-by: gtmnayan <50981692+gtm-nayan@users.noreply.github.com> Co-authored-by: Fernando López Guevara <fernando.lguevara@gmail.com> Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <richard.a.harris@gmail.com> Co-authored-by: Rich Harris <git@rich-harris.dev> Co-authored-by: Conner <conner@semicognitive.com> Co-authored-by: gtmnayan <gtmnayan@gmail.com> Co-authored-by: Loris Sigrist <43482866+LorisSigrist@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Frank <frank@sst.dev> Co-authored-by: Frank Dumont <fj.dumont@gmail.com> Co-authored-by: Reio Remma <reio@mrstuudio.ee>

vercel bot deployed to Preview – kit-svelte-dev May 11, 2023 23:09 View deployment

vercel bot deployed to Preview – kit May 12, 2023 04:47 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 12, 2023 04:49 View deployment

Base automatically changed from vitest to master May 13, 2023 20:54

chore: uvu -> vitest for create-svelte tests

84cd007

gtm-nayan force-pushed the create-svelte-tests-vitest branch from 526118f to 84cd007 Compare May 13, 2023 21:26

vercel bot deployed to Preview – kit May 13, 2023 21:27 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 13, 2023 21:30 View deployment

format

86654f0

vercel bot deployed to Preview – kit May 13, 2023 22:26 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 13, 2023 22:29 View deployment

gtm-nayan mentioned this pull request May 13, 2023

#9910 with concurrency #9921

Merged

5 tasks

concurrency (#9921)

fa39230

vercel bot deployed to Preview – kit May 13, 2023 22:44 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 13, 2023 22:47 View deployment

benmccann reviewed May 16, 2023

View reviewed changes

realised we werent typechecking this file, found some errors. fixed

9e1351f

vercel bot deployed to Preview – kit May 16, 2023 19:17 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 16, 2023 19:20 View deployment

gtm-nayan commented May 16, 2023

View reviewed changes

packages/create-svelte/test/check.js Outdated Show resolved Hide resolved

Wait for beforeAll hook to complete

0a50beb

vercel bot deployed to Preview – kit May 16, 2023 19:25 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 16, 2023 19:27 View deployment

simplify

14f524c

vercel bot deployed to Preview – kit May 16, 2023 19:57 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 16, 2023 20:00 View deployment

exclude create-svelte/template files from prettier, so that we can em…

aa188d4

…it correctly formatted templates

vercel bot deployed to Preview – kit May 16, 2023 20:06 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 16, 2023 20:09 View deployment

Merge branch 'master' into create-svelte-tests-vitest

3d2e439

vercel bot deployed to Preview – kit May 16, 2023 20:16 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 16, 2023 20:18 View deployment

Merge branch 'master' into create-svelte-tests-vitest

fbfe576

vercel bot deployed to Preview – kit May 16, 2023 20:57 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 16, 2023 20:59 View deployment

Rich Harris added 2 commits May 16, 2023 17:17

remove unused file

240a14f

Revert "exclude create-svelte/template files from prettier, so that w…

b36ad22

…e can emit correctly formatted templates" This reverts commit aa188d4.

vercel bot deployed to Preview – kit May 16, 2023 21:34 View deployment

vercel bot deployed to Preview – kit-svelte-dev May 16, 2023 21:37 View deployment

Rich-Harris approved these changes May 16, 2023

View reviewed changes

Rich-Harris merged commit 7042766 into master May 16, 2023

Rich-Harris deleted the create-svelte-tests-vitest branch May 16, 2023 22:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: uvu -> vitest for create-svelte tests #9910

chore: uvu -> vitest for create-svelte tests #9910

gtm-nayan commented May 11, 2023 •

edited by benmccann

Loading

changeset-bot bot commented May 11, 2023 •

edited

Loading

benmccann commented May 13, 2023

benmccann commented May 13, 2023

benmccann May 14, 2023

Rich-Harris May 16, 2023

benmccann May 16, 2023 •

edited

Loading

benmccann May 14, 2023

Rich-Harris May 16, 2023

benmccann May 16, 2023

Rich-Harris May 16, 2023

benmccann May 16, 2023

Rich-Harris commented May 16, 2023

Rich-Harris commented May 16, 2023

Rich-Harris commented May 16, 2023

	function patch_package_json(pkg) {
	function patch_package_json(pkg, overrides) {

chore: uvu -> vitest for create-svelte tests #9910

chore: uvu -> vitest for create-svelte tests #9910

Conversation

gtm-nayan commented May 11, 2023 • edited by benmccann Loading

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

Tests

Changesets

changeset-bot bot commented May 11, 2023 • edited Loading

⚠️ No Changeset found

benmccann commented May 13, 2023

benmccann commented May 13, 2023

benmccann May 14, 2023

Choose a reason for hiding this comment

Rich-Harris May 16, 2023

Choose a reason for hiding this comment

benmccann May 16, 2023 • edited Loading

Choose a reason for hiding this comment

benmccann May 14, 2023

Choose a reason for hiding this comment

Rich-Harris May 16, 2023

Choose a reason for hiding this comment

benmccann May 16, 2023

Choose a reason for hiding this comment

Rich-Harris May 16, 2023

Choose a reason for hiding this comment

benmccann May 16, 2023

Choose a reason for hiding this comment

Rich-Harris commented May 16, 2023

Rich-Harris commented May 16, 2023

Rich-Harris commented May 16, 2023

gtm-nayan commented May 11, 2023 •

edited by benmccann

Loading

changeset-bot bot commented May 11, 2023 •

edited

Loading

benmccann May 16, 2023 •

edited

Loading