Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass publicDir in ssr #9565

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix: pass publicDir in ssr #9565

merged 1 commit into from
Mar 30, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 30, 2023

We're not passing kit.files.assets to Vite's publicDir in SSR, which I believe is because we don't want to copy those files over in the SSR build?

This PR uses the new (experimental but stable) build.copyPublicDir: false option to prevent the copying instead. I'm not sure if there's anything else I miss, but the tests pass for me locally.

NOTE: I stumbled on this while building the new svelte.dev site as it generates a lot of warnings for missing references to public files, because the option is not set in SSR. This should fix it too.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Mar 30, 2023

🦋 Changeset detected

Latest commit: 9c5fa2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris Rich-Harris merged commit 5fa7820 into master Mar 30, 2023
@Rich-Harris Rich-Harris deleted the pass-public-dir-ssr branch March 30, 2023 19:01
@github-actions github-actions bot mentioned this pull request Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants