Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create separate functions for ISR routes #9504

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

Rich-Harris
Copy link
Member

Follow-up to #9182 — we disable streaming mode for ISR routes, but we don't consider config.isr when splitting functions in the first place. This means that if you have an SSR route and an ISR route that share the same config, one of two things will happen, depending on the order in which they're encountered during build:

  • the SSR route won't use streaming
  • the ISR route will 'fall back' to SSR

Both are undesirable. This fixes it

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@changeset-bot
Copy link

changeset-bot bot commented Mar 24, 2023

🦋 Changeset detected

Latest commit: 8d2383b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member Author

gonna do a cheeky self-merge so that this demo can be updated

@Rich-Harris Rich-Harris merged commit 707bfbe into master Mar 24, 2023
@Rich-Harris Rich-Harris deleted the vercel-isr-split branch March 24, 2023 19:31
@github-actions github-actions bot mentioned this pull request Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant