Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extending multiple other tsconfig in tsconfigs, typescript 5.0 #9413

Merged
merged 4 commits into from
Mar 13, 2023

Conversation

JeremyMoeglich
Copy link
Contributor

@JeremyMoeglich JeremyMoeglich commented Mar 12, 2023

closes #9412

Extending multiple tsconfigs in a tsconfig would previously result in a crash, now that works here, vite also needs changes though vitejs/vite#12380

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@JeremyMoeglich JeremyMoeglich changed the title Allow extending multiple other tsconfig in tsconfigs Allow extending multiple other tsconfig in tsconfigs, typescript 5.0 Mar 12, 2023
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

.changeset/metal-pugs-wink.md Outdated Show resolved Hide resolved
packages/kit/src/core/sync/write_tsconfig.js Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support tsconfig extending multiple tsconfigs, typescript 5.0
2 participants