Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark expiration as required #8943

Merged
merged 1 commit into from
Feb 8, 2023
Merged

fix: mark expiration as required #8943

merged 1 commit into from
Feb 8, 2023

Conversation

Rich-Harris
Copy link
Member

expiration is a required property when using isr (which, to be clear, doesn't currently work for unrelated reasons — working on it)

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@Rich-Harris Rich-Harris changed the title mark expiration as required chore: mark expiration as required Feb 8, 2023
@Rich-Harris Rich-Harris changed the title chore: mark expiration as required fix: mark expiration as required Feb 8, 2023
@Rich-Harris Rich-Harris merged commit 3fb80bd into master Feb 8, 2023
@Rich-Harris Rich-Harris deleted the required-expiration branch February 8, 2023 15:37
@github-actions github-actions bot mentioned this pull request Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants