Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: move adapter docs to site #8531

Merged
merged 25 commits into from
Jan 18, 2023
Merged

docs: move adapter docs to site #8531

merged 25 commits into from
Jan 18, 2023

Conversation

benmccann
Copy link
Member

@benmccann benmccann commented Jan 15, 2023

This builds off the docs PRs from @dummdidumm: #8501 and #8500

I ignored all the types errors in the docs. I don't know if there's a better way to set them up

dummdidumm and others added 4 commits January 13, 2023 11:40
Transforming the adapters document into a more general build doc
closes #8500
@changeset-bot
Copy link

changeset-bot bot commented Jan 15, 2023

🦋 Changeset detected

Latest commit: e782c12

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sveltejs/adapter-cloudflare-workers Patch
@sveltejs/adapter-auto Patch
@sveltejs/adapter-cloudflare Patch
@sveltejs/adapter-netlify Patch
@sveltejs/adapter-node Patch
@sveltejs/adapter-static Patch
@sveltejs/adapter-vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dummdidumm
Copy link
Member

dummdidumm commented Jan 16, 2023

I like this! I think I would rename the first doc to "fundamentals" and would rename the section heading "Build & Deploy", but that's all. Let's wait on more opinions before doing this.

@Rich-Harris
Copy link
Member

I think this is a good approach; will close #8500 and #8501 and do a proper edit of this branch tomorrow

This was referenced Jan 18, 2023
@dummdidumm
Copy link
Member

Really like the structure! Wondering if "static site generation" is the right title since you also can build SPAs with it (a regular point of confusion). Maybe it's even benefitial to have a dedicated page for that? Could be something along the lines of "spas are x, you can create them like y, they are supported by various adapters. If the whole app is an spa, you can use the static adapter, see link for more info (links back to static site generation).

@Rich-Harris
Copy link
Member

Re SPAs — #8531 (comment) (you can build an 'SPA' with any adapter, since it describes rendering rather than static-ness). I could be persuaded that we need a new page for SPAs, distinct from build & deploy, as long as it includes 'why you probably shouldn't build an SPA', but i think we can tackle that separately

@Rich-Harris
Copy link
Member

I don't like how tall this section is relative to the others — it feels disproportionate. But I don't think there's an easy solution within the current structure so I guess we go along with it for now

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants