docs: explain why typescript is added either way #8484
Conversation
for a library project closes #8189
🦋 Changeset detectedLatest commit: e47149a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/create-svelte/bin.js
Outdated
| @@ -136,6 +136,10 @@ async function main() { | |||
| } else if (options.types === 'checkjs') { | |||
| console.log(bold('✔ Type-checked JavaScript')); | |||
| console.log(' https://www.typescriptlang.org/tsconfig#checkJs'); | |||
| } else if (options.template === 'skeletonlib') { | |||
| console.log( | |||
| '🛈 You chose to not add type checking, but TypeScript will still be installed in order to generate type definitions when building the library' | |||
There was a problem hiding this comment.
what character is this supposed to be? it shows up empty in my terminal
There was a problem hiding this comment.
Huh, I saw it locally - it's supposed to be an info sign
There was a problem hiding this comment.
I replaced it with a warning sign, which looks better in combination with the check marks anyway - hopefully you see that one now
There was a problem hiding this comment.
i do, though the ⚠ character tends to look awful in a terminal context — on this MBP, where excellent font rendering is something you take for granted, it's a pixelated mess. I swapped it out for a yellow ▲ character instead
|
"You chose to not add type checking, but TypeScript will still be installed in order to generate type definitions when building the library". Must projects never do this. so no, it is not a reason at all. |
This change only applies if you create a library project. If you're creating a library project then yeah, you're gonna build it |
Thanks for clarification. Thought it was always installed. You never know these days. |
for a library project
closes #8189
also always add jsconfig.json, closes #7475
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.