Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude Node 17.x as supported version #8174

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

Conduitry
Copy link
Member

Closes #8173. The >=16.14 range also includes Node 17, which (apparently at least in some versions) doesn't support the three-argument version of util.inspect.custom. People shouldn't be using Node 17 anyway. I think we can make this change as a fix rather than as a breaking change.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@vercel
Copy link

vercel bot commented Dec 15, 2022

@Conduitry is attempting to deploy a commit to the Svelte Team on Vercel.

A member of the Team first needs to authorize it.

@changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2022

🦋 Changeset detected

Latest commit: ac90f0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sveltejs/kit Patch
@sveltejs/package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member Author

I really can't tell what all these test and deployment failures are about. I don't see how they could be related to this change.

@dummdidumm
Copy link
Member

(I approved because I think Node 17 being a non-LTS line and unsupported at this point is a good-enough reason to make this change right now when 1.0 is so fresh still; it will probably break right away for anyone using it anyway, as the issue shows)

@Rich-Harris Rich-Harris merged commit de5b8aa into sveltejs:master Dec 15, 2022
@github-actions github-actions bot mentioned this pull request Dec 15, 2022
@Conduitry Conduitry deleted the engines-exclude-node-17 branch December 15, 2022 16:43
@colinhowells
Copy link

Question about Cloudflare – right now they ask for 17 for Pages projects, wondering what the impact there might be

@Conduitry
Copy link
Member Author

That's annoying. Thanks. I've opened a PR cloudflare/cloudflare-docs#7043

@colinhowells
Copy link

colinhowells commented Dec 15, 2022

I'm also not sure if anything above 17 is available, last time I tried 18 it wasn't. Let me try a build now ...

Nope: Failed to install node version '18'

edit: their container is a bit weird (Node 12 by default, PHP 5.6?), and they know this, but it's taking a while for them to update everything in it, so this may be a good prod to make that happen

@Conduitry
Copy link
Member Author

Do you know what version of Node 16 you get if you specify NODE_VERSION=16? Is it at least 16.14, the minimum version needed by SvelteKit?

@colinhowells
Copy link

Let's see ... 16.19.0.

I can go around to my existing Pages projects and switch everything to 16, just in case it takes a while for Flare to get on it.

When you ask for 17 you get 17.9.1, fyi

robBowes pushed a commit to robBowes/kit that referenced this pull request Dec 20, 2022
* explicitly exclude Node 17.x in supported versions

* add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: inspect is not a function at URL.tracked.<computed>
5 participants