Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed getStaticDirectory() #7809

Merged
merged 2 commits into from
Nov 26, 2022
Merged

Removed getStaticDirectory() #7809

merged 2 commits into from
Nov 26, 2022

Conversation

mjh316
Copy link
Contributor

@mjh316 mjh316 commented Nov 25, 2022

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Removes getStaticDirectory() because of no more usage, as stated in #7800.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2022

🦋 Changeset detected

Latest commit: 1a22ec3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mjh316
Copy link
Contributor Author

mjh316 commented Nov 25, 2022

It seems svelte-adapter-firebase has one usage.
Other than that, all the adapters on https://sveltesociety.dev/components#adapters do not use it.

@dummdidumm
Copy link
Member

Thank you! We should ask them for what exactly they need it and if they can use something else to achieve what they want before merging this.

@benmccann
Copy link
Member

@jthegedus it would be interesting to get your input on this PR. thanks!

@jthegedus
Copy link
Contributor

jthegedus commented Nov 26, 2022

We are using this in the Firebase adapter to resolve #587 in our own way, but I believe we can work around it regardless. I need to do a big update/rewrite of the adapter now a lot of things have changed in Firebase and Kit.

Thanks for the consideration Ben 🙏

@Rich-Harris Rich-Harris merged commit 29c5f9d into sveltejs:master Nov 26, 2022
@Rich-Harris
Copy link
Member

thank you!

@benmccann
Copy link
Member

@jthegedus I was just reading your comment (#587 (comment)) on that issue to make sure we didn't cause you any trouble by merging this. What I would recommend is copying the assets from the output directory. The output directory will contain both the generated application files and assets from the static directory which should probably all be served by the CDN as they'll all static assets. Let me know if that would work or if there's anything I can do otherwise to help you get things running on the latest version of SvelteKit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants