Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] explain ramifications of base path #7095

Merged
merged 6 commits into from
Sep 30, 2022
Merged

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Sep 30, 2022

Closes #4528

On thing I'm wondering is if we should auto-prepend the base path when using goto. This is an API under our control, so we could safe people from prepending it there all the time. It would probably be a breaking change though for everyone who already does this. And it would also probably need an option to turn it off if you actually want to redirect relative to the domain root. So maybe ... don't do this after all?

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 30, 2022

🦋 Changeset detected

Latest commit: d03ad65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

dummdidumm and others added 2 commits September 30, 2022 16:09
Co-authored-by: Conduitry <git@chor.date>
Co-authored-by: Conduitry <git@chor.date>
Co-authored-by: Geoff Rich <4992896+geoffrich@users.noreply.github.com>
@Rich-Harris Rich-Harris merged commit df7eda9 into master Sep 30, 2022
@Rich-Harris Rich-Harris deleted the base-path-docs branch September 30, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting paths.base in svelte.config.js causes adapter-static to fail (404)
4 participants