Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set .eslintrc.ts.cjs to ignore all .cjs files. #707

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

jimpala
Copy link
Contributor

@jimpala jimpala commented Mar 26, 2021

Just a quick fix for #706 (using the first option I suggested). It gets the ESLint config to ignore all .cjs files, which gets rid of the complaints in those .cjs files that it isn't really configured to lint.
Feel free to use it if it does the job 🙂

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts

@vercel
Copy link

vercel bot commented Mar 26, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sveltejs/kit/x18gVoWLickHJyM9JQVaHqvPqq77
✅ Preview: Canceled

@dummdidumm dummdidumm merged commit 9a664e1 into sveltejs:master Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants