Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] silence prop warnings #6798

Merged
merged 1 commit into from
Sep 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-flowers-doubt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

[fix] silence prop warnings
32 changes: 17 additions & 15 deletions packages/kit/src/runtime/client/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ function update_scroll_positions(index) {
scroll_positions[index] = scroll_state();
}

// TODO remove for 1.0
/** @type {Record<string, true>} */
let warned_about_attributes = {};

Expand Down Expand Up @@ -1545,25 +1546,26 @@ function add_url_properties(type, target) {

function pre_update() {
if (__SVELTEKIT_DEV__) {
// Nasty hack to silence harmless warnings the user can do nothing about
const warn = console.warn;
console.warn = (...args) => {
if (
args.length === 1 &&
/<(Layout|Page)(_[\w$]+)?> was created (with unknown|without expected) prop '(data|form)'/.test(
args[0]
)
) {
return;
}
warn(...args);
};

return () => {
tick().then(() => (console.warn = warn));
check_for_removed_attributes();
};
}

return () => {};
}

if (__SVELTEKIT_DEV__) {
// Nasty hack to silence harmless warnings the user can do nothing about
const warn = console.warn;
console.warn = (...args) => {
if (
args.length === 1 &&
/<(Layout|Page)(_[\w$]+)?> was created (with unknown|without expected) prop '(data|form)'/.test(
args[0]
)
) {
return;
}
warn(...args);
};
}