Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "for an external resource" from the definition of handleFetch #6713

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Remove "for an external resource" from the definition of handleFetch #6713

merged 1 commit into from
Sep 12, 2022

Conversation

aradalvand
Copy link
Contributor

@aradalvand aradalvand commented Sep 9, 2022

#6565 replaced the externalFetch hook with a more generic handleFetch which isn't specific to requests with external URLs. I think this part of the documentation wasn't updated to reflect that, it should no longer say "...for an external resource..." in the definition of the handleFetch hook.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Sep 9, 2022

⚠️ No Changeset found

Latest commit: 4015625

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aradalvand aradalvand changed the title Remove for an external URL from the definition of handleFetch Remove "for an external resource" from the definition of handleFetch Sep 9, 2022
@benmccann benmccann added the documentation Improvements or additions to documentation label Sep 10, 2022
@dummdidumm dummdidumm merged commit 5311b53 into sveltejs:master Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants