-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace router
/hydrate
options with csr
#6446
Conversation
🦋 Changeset detectedLatest commit: 977ad1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @Rich-Harris ! I read in this PR that I should use this to keep same usage:
Unfortunately links like |
@MaximeMenotti To me, this is simply a bug that needs to be reported separately. |
Migration
export const router
andexport const hydrate
where merged intoexport const csr
. These two options really belong together, setting one to true and the other to false resulted in unexpected/buggy behavior. To migrate, remove the old options and replace them with the new option.The following permutations are possible:
router = true
/hydrate = true
-> new:csr = true
(this is the default, so you probably don't need to set this)router = false
/hydrate = false
-> new:csr = false
(no JS is loaded on the client)router = false
/hydrate = true
-> new:csr = true
+ setdata-sveltekit-reload
if you want native navigationsrouter = true
/hydrate = false
-> new:csr = true
(this was a buggy setting)PR description
closes #6436
TODO:
create-svelte
templateshydrate
orrouter
exportsPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm test
and lint the project withpnpm lint
andpnpm check
Changesets
pnpm changeset
and following the prompts. All changesets should bepatch
until SvelteKit 1.0