Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 docs: Added documentations about Server Sent Events (SSE) #5701

Closed
wants to merge 1 commit into from

Conversation

bastiaanv
Copy link

Adds documentation about Server Sent Events. See #887

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

⚠️ No Changeset found

Latest commit: 811a49e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

This is a good recipe, though I'm not sure if this is the right place for this. The other docs are related to explaining SvelteKit concepts, this is more of a how-to. We don't have a good section for things like this yet (learn.svelte.dev could become that).

@Rich-Harris
Copy link
Member

Agree, this is useful stuff but unfortunately it doesn't belong in the reference docs, it belongs in something like https://learn.svelte.dev/recipes (spoiler: that link 404s), so I have to close it — thank you and sorry!

There's also a significant wrinkle here: it assumes a single origin server. If you deploy your app to one of the many serverless platforms, different clients will connect to different instances of the server, which makes the whole thing fall apart. To build an app like the one in this PR we'd really need something along the lines of https://deno.com/deploy/docs/runtime-broadcast-channel; whether it's possible to expose that idea in a cross-platform way is very much TBD.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants