remove vite.config.js files #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conduitry
reviewed
Mar 18, 2021
| @@ -43,6 +43,7 @@ export type ValidatedConfig = { | |||
| pages: string[]; | |||
| }; | |||
| target: string; | |||
| vite: () => {}; | |||
There was a problem hiding this comment.
Is this not used for user-facing types, so there's no need to say that vite may be an object instead of a function that returns one?
There was a problem hiding this comment.
It's not, it's just for validated config. Forgot to update the types for user-facing config. Done: f8f7e70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves Vite config into svelte.config.cjs, per #509. For now it doesn't differentiate between the config requirements for different Vite builds, since that involves making API design decisions that might be premature.
It also allows
config.kit.viteto be a simple object, since that will cover the majority of cases.