Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump prettier format print width #5588

Merged
merged 1 commit into from
Jul 18, 2022
Merged

bump prettier format print width #5588

merged 1 commit into from
Jul 18, 2022

Conversation

ignatiusmb
Copy link
Member

Makes it just a tad bit nicer to read, some examples (making it in one column so that the images are still visible)

Before/After
1. Load
image
image
2. RequestHandler & RequestHandlerOutput
image
image
3. etc.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 18, 2022

⚠️ No Changeset found

Latest commit: c718e66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

Interesting that it was set to 60 (default is 80 which I still think is small) - for small mobile phones?

@ignatiusmb
Copy link
Member Author

Yep, it was mentioned that some were a bit difficult to read on mobile, I believe it was previously unformatted which makes it horizontally long to scroll on small mobile, but 60 is too small and makes it hard to read on desktop instead

@Rich-Harris
Copy link
Member

i'd guess most of the time our docs are being read on desktop, so this makes sense to be. the galaxy brain move would be to reformat dynamically based on width, but that would result in hydration shift unless we figured out a media-query-based solution, which would be hellishly complex

@Rich-Harris Rich-Harris merged commit eb85ec3 into master Jul 18, 2022
@Rich-Harris Rich-Harris deleted the print-width branch July 18, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants