[chore] test using windows-latest #5503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rich-Harris
approved these changes
Jul 13, 2022
|
when github ci windows-latest switched from 2019 to 2022, the 2022 runners were not really stable. That was months ago so the situation has likely improved. I'd hope that our CI passes on either though 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dominikg reported that this repo doesn't build on WIndows 10. The
windows-latesttag will use Windows Server 2022 instead of Windows Server 2019, so I was curious if that would pick up the build failure. It doesn't but maybe is still worth usingwindows-latestto align with the fact that we useubuntu-latest. Or should we pin it to 2022 so that if things break when they update the latest we won't be surprised?