Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-svelte: include globals.d.ts in tsconfig #549

Merged
merged 3 commits into from
Mar 18, 2021
Merged

Conversation

GrygrFlzr
Copy link
Member

Apparently globals.d.ts was being ignored entirely. Whoops.

@benmccann
Copy link
Member

benmccann commented Mar 16, 2021

Perhaps we should put it in src for better organization and include src/**/*.d.ts?

Also, it seems more common to call it global.d.ts. I'm guessing that doesn't really matter for the most part, but might make it easier for people who don't know what it is to search and find results online

@dummdidumm
Copy link
Member

+1 on putting it inside src. +1 on adding src/**/*.d.ts. Name - I don't care 😄

@orta
Copy link

orta commented Mar 17, 2021

If I recall next js puts the d.ts in src, seems pretty reasonable to think of it as a source file to me

@GrygrFlzr
Copy link
Member Author

Moved to /src/global.d.ts as recommended above.

@dummdidumm dummdidumm merged commit c04887c into master Mar 18, 2021
@dummdidumm dummdidumm deleted the fix-tsconfig branch March 18, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants