Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] omit Connection header from requests made by load fetch #5393

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

Conduitry
Copy link
Member

This should resolve at least part of #5380. It might be that this ends up being the only thing we want to do as part of that issue. This PR is similar to #3690 which omitted the Host header.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2022

🦋 Changeset detected

Latest commit: dfc0a54

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Conduitry
Copy link
Member Author

So, this time I lied about having run the tests locally. It looks like some tests need to be updated. Before I do so, I would like to confirm with @Rich-Harris that this is what you were suggesting happen in your comments on #5380.

@Rich-Harris
Copy link
Member

It is

@Rich-Harris Rich-Harris merged commit 43504ba into sveltejs:master Jul 6, 2022
@github-actions github-actions bot mentioned this pull request Jul 6, 2022
@Conduitry Conduitry deleted the load-omit-connection-header branch July 6, 2022 20:45
@github-actions github-actions bot mentioned this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants